Skip to content

Conversation

pamelafox
Copy link
Collaborator

@pamelafox pamelafox commented Nov 4, 2024

Purpose

Fixes #1339, fixes #2033

We no longer need to have the azd dotenv task as a dependency, as our code in main.py loads in the azd environment dynamically. Given the issues caused loading that task in Codespaces, it's better to remove it entirely.

I also went ahead and added a nice combo configuration and some docs while I was at it.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[X] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[X] No

Type of change

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

N/A

Test plan

I tested frontend, backend, and the combination.

@pamelafox pamelafox merged commit f3a4c1e into Azure-Samples:main Nov 5, 2024
13 checks passed
@pamelafox pamelafox deleted the launchfix branch November 5, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants